Skip to content

Conversation

@dboyliao
Copy link
Contributor

  • Setup docker environment for development
  • Add README for instructions of building docker environment

@dboyliao
Copy link
Contributor Author

FYI, I'm able to build modmesh and import it in the docker container.

@yungyuc yungyuc added the enhancement New feature or request label Sep 11, 2022
@dboyliao
Copy link
Contributor Author

Screen Shot 2022-09-11 at 3 04 55 PM

I run the CI locally and the error is due to missingpip3 command.
Looks like pip is not installed correctly in the CI image

@yungyuc
Copy link
Member

yungyuc commented Sep 11, 2022

Screen Shot 2022-09-11 at 3 04 55 PM

I run the CI locally and the error is due to missingpip3 command. Looks like pip is not installed correctly in the CI image

Could you please provide a link to the error at your CI run? Image is not helpful in pin-pointing the error.

The nightly CI is healthy: https://github.com/solvcon/modmesh/actions/runs/3028860237 . I would guess the error comes from your change.

@dboyliao
Copy link
Contributor Author

Screen Shot 2022-09-11 at 3 04 55 PM I run the CI locally and the error is due to missing`pip3` command. Looks like `pip` is not installed correctly in the CI image

Could you please provide a link to the error at your CI run? Image is not helpful in pin-pointing the error.

The nightly CI is healthy: https://github.com/solvcon/modmesh/actions/runs/3028860237 . I would guess the error comes from your change.

I'm using act to run the CI locally.
https://github.com/nektos/act

After inspecting the workflow, that's because I use pyenv on my machine and it's fighting with it.
My PR should not introduce any CI-breaking change after all.

- not recommended offically
- building instructions in `/contrib/docker/README.md`
@yungyuc yungyuc merged commit d694b6a into solvcon:master Sep 11, 2022
@yungyuc
Copy link
Member

yungyuc commented Sep 11, 2022

LGTM. Thanks for the PR.

@tigercosmos
Copy link
Collaborator

wow love it!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants