Skip to content

Port to windows and Add windows build test to modmesh_viewer CI workflow #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 17, 2022
Merged

Port to windows and Add windows build test to modmesh_viewer CI workflow #122

merged 5 commits into from
Sep 17, 2022

Conversation

@tychuang1211
Copy link
Collaborator

@tychuang1211 tychuang1211 commented Sep 16, 2022

#106

  1. Support building with MSVC
  2. Add OS windows-2022 to CI workflow

@yungyuc yungyuc added the test testing and continuous integration label Sep 16, 2022
yungyuc
yungyuc requested changes Sep 16, 2022
View reviewed changes
Copy link
Member

@yungyuc yungyuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exciting! wakuwaku

cpp/modmesh/spacetime/core.hpp

#include <memory>
#include <vector>
#include <functional>
Copy link
Member

@yungyuc yungyuc Sep 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

tychuang1211
tychuang1211 commented Sep 16, 2022
View reviewed changes
@yungyuc yungyuc merged commit d4cd390 into solvcon:master Sep 17, 2022
@yungyuc
Copy link
Member

yungyuc commented Sep 17, 2022

This is wonderful. Thank you so much, @tychuang1211

@tychuang1211 tychuang1211 deleted the 106-windows-viewer-ci branch November 24, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yungyuc yungyuc yungyuc approved these changes

Assignees

@yungyuc yungyuc

@tychuang1211 tychuang1211

Labels

test testing and continuous integration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tychuang1211 @yungyuc @tychuang2385