Create Python middle layer for the 1D Euler solver #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add helper functions for setting up the Sod's shock tube problem.
The word "core" means it is the computing core. I use "kernel" to refer to different constructs and they should not be interchangeable. I plan to use the word "solver" for high-level construct that is in Python, not in C++.
Currently the package modmesh.onedim contains a single solver for the Euler equations. Later we can add solvers for other equations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the C++ class implementing the 1D CESE method for the Euler equations to
Euler1DCore, denoting the calculation core. Make a new Python class named like the old C++ class:Euler1DSolver, working as the middle layer in Python.The Python middle layer allows us to implementing logic that does not need the speed of C++ (not in a tight loop, or Python/numpy is sufficiently fast) in Python. Being able to write Python significantly help coding productivity.