Enable external ownership of ConcreteBuffer #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Drop the unnecessary deleter class from the ConcreteBuffer and SimpleArray.
* Take remover and deleter classes outside ConcreteBuffer to work around for a bug in g++ 7: https://bugzilla.redhat.com/show_bug.cgi?id=1569374 . * Fix gcc visibility in the pybind11 wrapper file. * Add default constructor of ConcreteBufferNdarrayRemover to make it work with unique_ptr * Supply the deleter object to unique_ptr constructor. * Remove unnecessary else.
Member
Author
|
@tigercosmos This may be an example for the 'system-level' work that should be done for the mesh code base. For your information. Feel free to comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests to allow the internal data buffer of
ConcreteBufferto be owned outside the shared-pointer-controlled object. Before the change, creation ofConcreteBuffermandates dynamic memory allocation.A custom
std::unique_ptrDeleteris added to support memory management of the internal buffer ofConcreteBuffer. The customerDeleteruses a polymorphic "remover" to control the lifecycle of the internal buffer. By default, the remover is null, and theDeleterbehaves the same asstd::default_delete<T>.The
removermakes it possible to bind the lifecycle of the internal data buffer outside. For example,struct ConcreteBufferNdarrayRemoveris derived fromConcreteBuffer::remover_typeand bind the lifecycle of the buffer to aPyArrayObject(i.e.,pybind11::array).