Add a new --mode=python by using the standard Python interpreter entry point #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Py_BytesMain is the stable API to enter the standard interpreter from an embedding executable: https://docs.python.org/3.10/c-api/veryhigh.html#c.Py_BytesMain Create the new class ProcessInfo and the member datum CommandLineInfo. CommandLineInfo provides the flags processed from the command line arguments to provide information for the execution mode.
yungyuc
commented
Oct 29, 2022
|
|
||
| if (clinfo.python_main()) | ||
| { | ||
| ret = Py_BytesMain(clinfo.python_main_argc(), clinfo.python_main_argv_ptr()); |
Member
Author
There was a problem hiding this comment.
Py_BytesMain() finalizes the interpreter when returning.
| modmesh::python::Interpreter::instance().setup_process(argc, argv); | ||
| modmesh::python::Interpreter::instance().finalize(); | ||
| return 0; | ||
| return ret; |
| #include <stdexcept> | ||
| #include <array> | ||
| #include <vector> | ||
| #include <algorithm> |
| Interpreter & setup_process(int argc, char ** argv); | ||
| Interpreter & setup_process(); | ||
|
|
||
| int enter_main(); |
Member
Author
There was a problem hiding this comment.
Add the "main" an inverse wrapper to call the Python entry function from C++.
| for (int i = 0; i < argc; ++i) | ||
| { | ||
| std::string const & arg = m_populated_argv[i]; | ||
| if ("--mode=python" == arg) |
Member
Author
There was a problem hiding this comment.
Remove --mode=python from the command-line argument for Py_BytesMain.
Member
Author
|
Take command: Interactive mode: Run module: |
Member
Author
|
This PR makes #103 more complete. |
Member
Author
|
The new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
Py_BytesMainfor the "python" mode of viewer.Py_BytesMainis the stable API to enter the standard interpreter from an embedding executable: https://docs.python.org/3.10/c-api/veryhigh.html#c.Py_BytesMainCreate the new class ProcessInfo and the member datum CommandLineInfo. CommandLineInfo provides the flags processed from the command line arguments to provide information for the execution mode.