Enable clang-tidy on the viewer #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yungyuc
commented
Oct 29, 2022
Member
Author
yungyuc
left a comment
yungyuc
left a comment
There was a problem hiding this comment.
Increase clang-tidy coverage by moving from the Python-only extension to viewer.
| run: make cinclude | ||
|
|
||
| - name: make buildext | ||
| - name: make viewer |
| ${JOB_MAKE_ARGS} \ | ||
| CMAKE_BUILD_TYPE=${{ matrix.cmake_build_type }} \ | ||
| CJOB_MAKE_ARGS="-DPYTHON_EXECUTABLE=$(which python3)" | ||
| CMAKE_ARGS="-DPYTHON_EXECUTABLE=$(which python3)" |
| - name: make run_viewer_pytest | ||
| run: | | ||
| make pytest \ | ||
| make run_viewer_pytest \ |
Member
Author
There was a problem hiding this comment.
Use the viewer binary to test.
| clean: | ||
| rm -f $(MODMESH_ROOT)/modmesh/_modmesh$(pyextsuffix) | ||
| make -C $(BUILD_PATH) clean | ||
| .PHONY: cmake |
|
|
||
| .PHONY: buildext | ||
| buildext: cmake | ||
| cmake --build $(BUILD_PATH) --target _modmesh_py VERBOSE=$(VERBOSE) $(MAKE_PARALLEL) |
Member
Author
There was a problem hiding this comment.
Change to use cmake targets.
| if(CLANG_TIDY_EXE AND USE_CLANG_TIDY) | ||
| set_target_properties( | ||
| viewer PROPERTIES | ||
| CXX_CLANG_TIDY "${DO_CLANG_TIDY}" |
Member
Author
There was a problem hiding this comment.
Use clang-tidy to viewer binary.
|
|
||
| # Hack: add a .clang-tidy file in the generated .rcc directory. | ||
| # See https://gitlab.kitware.com/cmake/cmake/-/merge_requests/777 | ||
| file(WRITE "${viewer_BINARY_DIR}/.rcc/.clang-tidy" "--- |
Member
Author
There was a problem hiding this comment.
There should be a better way to do it, but that's what I can find after dinner.
| public: | ||
|
|
||
| RScene(Qt3DCore::QNode * parent = nullptr) | ||
| explicit RScene(Qt3DCore::QNode * parent = nullptr) |
| @@ -0,0 +1,2 @@ | |||
| Checks: > | |||
| -cppcoreguidelines-owning-memory No newline at end of file | |||
Member
Author
There was a problem hiding this comment.
qt tends to have way too many raw pointers so I have to turn this off.
| } | ||
|
|
||
| RApplication::~RApplication() | ||
| { |
Member
Author
There was a problem hiding this comment.
Python finalization is taken care of elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.