Allow negative value for the ghost index in the first dimension of SimpleArray #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add a constructor of small_vector taking initiali value. 2. Add a pointer m_body to the start of the body data in SimpleArray. 3. Improve the index validation with the ghost index support. 1. Add multi-dimensional index validation. 2. When ghost is non-trivial, the flat indexing only works with 1-dimensional arrays. 3. Add Python unit tests.
Remove the clang-tidy error of "readability-else-after-return".
yungyuc
commented
Nov 14, 2021
| self.assertEqual((1, 24), sarr.reshape((1, 24)).shape) | ||
| self.assertEqual((12, 2), sarr.reshape((12, 2)).shape) | ||
|
|
||
| def test_SimpleArray_ghost_1d(self): |
Member
Author
There was a problem hiding this comment.
Test for ghost index for 1D arrays.
| ): | ||
| sarr[14] = 1 | ||
|
|
||
| def test_SimpleArray_ghost_md(self): |
Member
Author
There was a problem hiding this comment.
Test the ghost index for the multi-dimensional arrays.
| r"SimpleArray::validate_range\(\): cannot handle 3-dimensional " | ||
| r"\(more than 1\) array with non-zero nghost: 1" | ||
| ): | ||
| sarr[-1] |
Member
Author
There was a problem hiding this comment.
For multi-dimensional arrays, the single-index ghost index should not work at all.
| } | ||
| } | ||
| ) | ||
| .def("__getitem__", [](wrapped_type const & self, ssize_t key) { return self.at(key); }) |
Member
Author
There was a problem hiding this comment.
Make getitem and setitem cleaner.
|
|
||
| template < typename ... Args > | ||
| value_type const & operator()(Args ... args) const { return data(buffer_offset(m_stride, args...)); } | ||
| value_type const & operator()(Args ... args) const { return m_body[buffer_offset(m_stride, args...)]; } |
Member
Author
There was a problem hiding this comment.
Use the body pointer to replace the original data pointer. This implements the ghost index access.
Member
Author
|
@y3jo6 Perhaps you may be interested in the code here. |
Member
Author
|
The code works fine and I am going to check in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ghost index works like the negative index in the POD array. In SimpleArray, it is only enabled in the first (leading dimension).
ref #20