[refactor] Add helpers to wrap member SimpleArray #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add SimpleArray::swap(). * Create modmesh::python::makeSimpleArray to create SimpleArray from ndarray (pybind11::array_t) buffer. * Use a more concuse declaration to return reference from lambda.
yungyuc
commented
Dec 12, 2021
|
|
||
| struct | ||
| MODMESH_PYTHON_WRAPPER_VISIBILITY | ||
| ConcreteBufferNdarrayRemover : ConcreteBuffer::remover_type |
Member
Author
There was a problem hiding this comment.
Move the remover to the common file.
| }; /* end struct ConcreteBufferNdarrayRemover */ | ||
|
|
||
| template < typename T > | ||
| static SimpleArray<T> makeSimpleArray(pybind11::array_t<T> & ndarr) |
Member
Author
There was a problem hiding this comment.
Helper function to convert from pybind11::array_t to SimpleArray while sharing the buffer.
| #undef DECL_MM_PYBIND_CLASS_METHOD | ||
|
|
||
| template < typename Func > | ||
| wrapper_type & expose_SimpleArray(char const * name, Func && f) |
Member
Author
There was a problem hiding this comment.
Wrapper helper for SimpleArray member accessors.
| std::swap(self.coord(), sarr); | ||
| } | ||
| ) | ||
| .expose_SimpleArray("coord", [](wrapped_type & self) -> decltype(auto) { return self.coord(); }) |
Member
Author
There was a problem hiding this comment.
Use decltype(auto) to make the line shorter.
|
|
||
| OneTimeInitializer<T> & operator()( | ||
| OneTimeInitializer<T> & operator() | ||
| ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modmesh::python::makeSimpleArrayto create SimpleArray from ndarray (pybind11::array_t) buffer.