Skip to content

Refactor build_faces_from_cells() to save some lines of code #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2022
Merged

Refactor build_faces_from_cells() to save some lines of code #41

merged 1 commit into from
Jan 2, 2022

Conversation

@yungyuc
Copy link
Member

@yungyuc yungyuc commented Jan 2, 2022

  • Add SimpleArray::vptr() API to return the pointer to an element.
  • Change the use of some local pointers with SimpleArray API.
  • Remove the constexpr FCNCL which is duplicated with FCREL.

@yungyuc
Refactor build_faces_from_cells() to save some lines of code
b5c2e48 
* Add SimpleArray::vptr() API to return the pointer to an element.
* Change the use of some local pointers with SimpleArray API.
@yungyuc yungyuc added the refactor Change code without changing tests label Jan 2, 2022
@yungyuc yungyuc self-assigned this Jan 2, 2022
@yungyuc yungyuc merged commit 1f0ace1 into solvcon:project/ustmesh Jan 2, 2022
@yungyuc yungyuc deleted the refactor/build_faces_from_cells branch January 2, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@yungyuc yungyuc

Labels

refactor Change code without changing tests

Projects

No open projects
Support multi-dimensional unstructured mesh
Status: done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@yungyuc