-
Notifications
You must be signed in to change notification settings - Fork 56
Add the minimal code for unstructured mesh #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ification The mesh is named StaticMesh* because it does not change when being used. 1. The code was copied from SOLVCON (https://github.com/solvcon/solvcon). 2. Add basic shape tests for the mesh object. 3. Add CellType but it is not used nor tested at all.
Add mesh.hpp to house code of unstructured mesh
… object This is the first step: Create a simple test function for the object creation.
Note that the cell type ID is augmented by 1 (the valid type ID started from 0 in SOLVCON, but now it starts from 1 in modmesh). Use of 1-based index leaves 0 to be the invalid sentinel for the type ID in modmesh. Use the trivial triangle unit tests for build_faces_from_cells().
Ref issue #34.
Ref issue #35.
Also include porting count_ghost() and fill_ghost(). Ref issue #36. Copy code from SOLVCON: https://github.com/solvcon/solvcon/blob/8dd74fa848b8d14d7796138ce199d0ae2e70235f/libmarch/include/march/mesh/UnstructuredBlock/class.hpp#L312.
Add code to build the data for 2D unstructured mesh object
Use std::algorithm to count maximal number of faces for interior data.
* Add SimpleArray::vptr() API to return the pointer to an element. * Change the use of some local pointers with SimpleArray API.
Remove use of pointers to shorten the code.
Add helper class detail::FaceBuilder to house the face building code. The helper functions include: * populate() * make_ndfcs() * make_dedupmap() * remap_face()
I wrongly coded it to be swap(SimpleArray && other). Change it to swap(SimpleArray & other). Also use noexcept for C++17.
…ension by reconstruction
Make the function a little bit flatter.
Ubuntu g++ 10 detected these missing includes.
Make inclusion more complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minimal unstructured-mesh code has the most basic unit test in 2D.