Add tests for SimpleArray #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yungyuc
requested changes
Mar 22, 2022
Member
yungyuc
left a comment
yungyuc
left a comment
There was a problem hiding this comment.
It will make the merge message more descriptive if branch name and the title of the PR to be more specific.
Contributor
Author
|
It's awkward that I accidentally closed the PR while renaming the branch... |
Member
|
Does github prevent you from reopening it? Let me try to do it ... |
Contributor
Author
It seems that I can only change the branch I want to merge and cannot change the target branch( |
yungyuc
reviewed
Mar 23, 2022
| IndexError, | ||
| r"SimpleArray::validate_shape\(\): empty index" | ||
| ): | ||
| invalid_empty_idx = () |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to add some test cases for
SimpleArray