Remove TimeRegistry related class and test #600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c1ydehhx
force-pushed
the
migrate_time_registry
branch
from
5a92354 to
2490cfd
Compare
yungyuc
requested changes
Oct 18, 2025
Member
yungyuc
left a comment
yungyuc
left a comment
There was a problem hiding this comment.
- Keep
StopWatchwhich is a convenient help for quick timing and add corresponding unit tests. - Fix the indentation.
- Do not change blank lines and whitespaces unnecessarily.
| (*this) | ||
| // clang-format off | ||
| .def_property_readonly_static("me", [](py::object const &) -> wrapped_type& { return wrapped_type::me(); }) | ||
| .def_property_readonly_static("me", [](py::object const &) -> wrapped_type& { return wrapped_type::me(); }) |
|
|
||
| }; /* end class WrapWrapperTimerStatus */ | ||
|
|
||
| class MODMESH_PYTHON_WRAPPER_VISIBILITY WrapStopWatch |
Member
There was a problem hiding this comment.
Please keep StopWatch which is a convenient help for quick timing and add corresponding unit tests.
|
|
||
| mod.attr("call_profiler") = mod.attr("CallProfiler").attr("instance"); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Do not change blank lines and whitespaces unnecessarily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new?
In this PR, I remove TimeRegistry related class and tests. Since we already complete #583, #582, and #581, it can be removed and use CallProfiler instead. So, I remove TimeRegistry related class and tests.
How to review it?
Please check all the tests is passed.