Fix viewer CMakeLists.txt #61
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aim to solve the raised error 1 when trying to build viewer
To solve this I copy the CXX_VISIBILITY flag settings in other CMakeLists.txt. 2
Also, I've set default value of
HIDE_SYMBOLtoONsince for now the only use case it is set to off is to combine it whenBUILD_QT=OFF. However in current Makefile it is default set toBUILD_QT=ON, so I assume by default the Makefile is targeting to build both modmesh and the viewer without providing additional arguments.Footnotes
https://pybind11.readthedocs.io/en/stable/faq.html#someclass-declared-with-greater-visibility-than-the-type-of-its-field-someclass-member-wattributes ↩
https://github.com/solvcon/modmesh/blob/master/src/pymod/CMakeLists.txt#L16 ↩