Refactor(simd): Improve clarity and consistency in dispatcher #632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed 'using namespace detail' to explicitly qualify function calls, improving code readability. Also removed redundant break statements and added NEON dispatch for the max function to be consistent with other SIMD operations.
yungyuc
requested changes
Nov 17, 2025
Member
yungyuc
left a comment
yungyuc
left a comment
There was a problem hiding this comment.
Always adding break after case in case a maintainer forgets about it after changing the code before it.
- Don't remove
breakeven if it is no-op.
| case SIMD_NEON: | ||
| case detail::SIMD_NEON: | ||
| return neon::add<T>(dest, dest_end, src1, src2); | ||
| break; |
Member
There was a problem hiding this comment.
Removing break is not conventional. Don't do it.
Author
There was a problem hiding this comment.
I initially removed the break statements because they were technically unreachable after a return, so I deleted the break statement to simplify the switch block code. But I understand your point now.
Member
|
Make sure CI passes before requesting for a review. You can run it in your local fork. |
Member
|
This PR is for issue #631 . |
Author
|
Thanks for the review & feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the
using namespace detailstatements and replaced them with explicit qualifiers to make the code easier to follow. Also removed redundant break statements and added NEON dispatch for the max function to be consistent with other SIMD operations. @yungyuc