Make StaticMesh a class instead of a template #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move big member functions to cpp files. That is, modmesh is no longer a header-only library. Maybe some parts in modmesh can be header only, but it may not be the mesh. Also, update viewer to use the class-version StaticMesh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modmesh::StaticMeshwas a template and I thought it may provide opportunities to optimize based on the dimensionality (2D/3D). However it makes scripting complicated because there needs to be two StaticMesh classes in Python (StaticMesh2dandStaticMesh3d).Perhaps it should not be so complicated? This PR attempts to remove the template and see how it looks in Python. Since we do not have any benchmarking, the performance consideration will be put aside for a while.