Skip to content

Conversation

@yungyuc
Copy link
Member

@yungyuc yungyuc commented May 8, 2022

The refactor includes:

  • Collect cpp and hpp files to a single directory.
  • Separate files of binary and shared object from the library code.
  • Separate the CMakeLists.txt file list variables in the directory hierarchy.
  • Separate wrapper building functions to distinct files for parallel build.
  • Create modmesh/buffer.hpp.
  • Fix error return of setup.py, which didn't return an error code when the sub processes fail. Fix by throwing an exception.

yungyuc added 3 commits May 8, 2022 08:10
setup.py didn't return an error code when the sub processes fail.  Fix by
throwing an exception.
Not all wrapper building functions are separated.
@yungyuc yungyuc added the refactor Change code without changing tests label May 8, 2022
@yungyuc yungyuc self-assigned this May 8, 2022
@yungyuc yungyuc closed this May 8, 2022
@yungyuc yungyuc reopened this May 8, 2022
@yungyuc yungyuc marked this pull request as draft May 8, 2022 00:16
* Separate files of binary and shared object from the library code.
* Separate the CMakeLists.txt file list variables in the directory hierarchy.
@yungyuc yungyuc marked this pull request as ready for review May 8, 2022 02:15
@yungyuc yungyuc merged commit 5a9beed into solvcon:master May 8, 2022
@yungyuc yungyuc deleted the refactor/file-organization branch May 8, 2022 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Change code without changing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant