ci(viewer): init CI run for viewer binary #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yungyuc
requested changes
May 24, 2022
Member
yungyuc
left a comment
yungyuc
left a comment
There was a problem hiding this comment.
Great addition! Could you fix the failed run and do some minor tweaks?
Member
|
@ianlienfa FYI |
yungyuc
approved these changes
May 28, 2022
Contributor
Author
|
Thanks for the follow-up fixup. I went to a holiday for several days without accessing internet! I hope everyone does not mind the late response. |
Member
|
No problem at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beginning to build the
viewerbinary with Ubuntu Jammy (22.04). The CI job will pass with Ubuntu, and will fail with macos. I leave the fix for macos to anyone with mac.Ref issue #75