Add a helper to convert QByteArray to SimpleArray #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the SimpleArray converter to improve bound-checking of the mesh coordinate data setup in RStaticMesh. Also fix a bug of missing m_nghost and m_body in the move constructor of SimpleArray.
yungyuc
commented
May 28, 2022
| *ptr++ = mh.ndcrd(ind, 0); | ||
| *ptr++ = mh.ndcrd(ind, 1); | ||
| *ptr++ = (3 == mh.ndim()) ? mh.ndcrd(ind, 2) : 0; | ||
| sarr(ind, 0) = mh.ndcrd(ind, 0); |
Member
Author
There was a problem hiding this comment.
Make the element setting code to be symmetric between the assignment.
The new intermediate runs slower, but looks nicer.
yungyuc
commented
May 28, 2022
| : m_buffer(std::move(other.m_buffer)) | ||
| , m_shape(std::move(other.m_shape)) | ||
| , m_stride(std::move(other.m_stride)) | ||
| , m_nghost(other.m_nghost) |
Member
Author
There was a problem hiding this comment.
For some reasons I forgot this in the past.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the SimpleArray converter to improve bound-checking of the mesh coordinate data setup in RStaticMesh.
Also fix a bug of missing m_nghost and m_body in the move constructor of SimpleArray.