Skip to content

Conversation

@yungyuc
Copy link
Member

@yungyuc yungyuc commented Apr 26, 2020

GitHub Action seemed to update its macOS image and the way I installed numpy does not work any more. Taking this opportunity I update the CI script as well as some other things:

  • Use pip to install numpy on macOS.
  • Add -Werror -Wall -Wextra to build the Python extension.
  • Add -Wno-unused-value for PYBIND11_EXPAND_SIDE_EFFECTS in pybind11.h
  • Add -Wno-noexcept-type for GCC
  • Ignore -Wextra for allowing calling the base default constructor for ConcreteBuffer (use #pragma).

@yungyuc yungyuc merged commit 55103a3 into master Apr 26, 2020
@yungyuc yungyuc deleted the feature/compiler-warnings branch April 26, 2020 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants