feat: Support menubar #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanagiragi
force-pushed
the
59-add-menubar
branch
from
498d5ae to
9aa7650
Compare
yungyuc
reviewed
Jun 11, 2022
| qDebug() << "Create new file!"; | ||
| }); | ||
| RAction * exitAction = new RAction( | ||
| QString("Exit"), |
Member
There was a problem hiding this comment.
Interestingly, on mac, when this menu item string is Exit, the item does not show. It shows after the string changes to something else. I will study why it happens and fix it later.
Contributor
Author
There was a problem hiding this comment.
To be clear, the case we discovered should be the menu item string starts with Exit, not sure the contains Exit will also fail or not.
yungyuc
approved these changes
Jun 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #59 and add basic example: