Do not add "exit" menu item when it is macos #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://doc.qt.io/qt-6/qmenubar.html#qmenubar-as-a-global-menu-bar . When it is macos, Qt search for "quit" or "exit" menu item and merge them with the corresponding item in the default menu. It does not need to be added by the app.
yungyuc
commented
Jun 12, 2022
Member
Author
yungyuc
left a comment
yungyuc
left a comment
There was a problem hiding this comment.
@yanagiragi Let me know if this looks good to you.
|
|
||
| RMenuBar * menuBar = new RMenuBar(); | ||
| RMenu * fileMmenu = new RMenu(QString("File")); | ||
| RMenu * fileMenu = new RMenu(QString("File")); |
Contributor
There was a problem hiding this comment.
Yes. I believe this is a typo.
| newMenu->addAction(newFileAction); | ||
| fileMenu->addMenu(newMenu); | ||
|
|
||
| #ifndef Q_OS_MACOS |
Member
Author
There was a problem hiding this comment.
Only build this when this is not in mac.
Member
Author
|
ref #59 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://doc.qt.io/qt-6/qmenubar.html#qmenubar-as-a-global-menu-bar . When it is macos, Qt search for "quit" or "exit" menu item and merge them with the corresponding item in the default menu. It does not need to be added by the app.
Also fix a typo for
fileMenu.