Remove duplicated edges when drawing the wireframe of a mesh #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to address issue solvcon#68. A new array `ednds` is added to StaticMesh. Each row contains the two nodes forming the edge, from the tail to head. A new (private) argument _build_edge is added to StaticMesh.build_interior() and its default value is False. A standalone function build_edge() is added to StaticMesh too. RStaticMesh::update_geometry_impl() is updated to use the new ednds array. A new free helper function makeQByteArray() is added to copy the data from a SimpleArray to Qt QByteArray.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address issue #68.
A new array
edndsis added to StaticMesh. Each row contains the two nodes forming the edge, from the tail to head.A new (private) argument _build_edge is added to StaticMesh.build_interior() and its default value is False. A standalone function build_edge() is added to StaticMesh too.
RStaticMesh::update_geometry_impl() is updated to use the new ednds array.
A new free helper function makeQByteArray() is added to copy the data from a SimpleArray to Qt QByteArray.