Refactor: Embed the base Python extension module to the viewer executable #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able The "base" _modmesh Python extension module was built in a separate shared object and loaded into the viewer binary. Some object files need to be linked in the two images. It is unnecessarily complex. Embedding the "base" Python extension module in the same way that the "_modmesh_view" module is embedded to the viewer executable simplifies the linkage. The pure Python module (package) `modmesh` is changed accordingly. When it is used without the Qt viewer, it still tries to load the `_modmesh` extension module relatively.
yungyuc
added
refactor
yungyuc
commented
Jun 26, 2022
| #include <modmesh/view/view.hpp> | ||
|
|
||
| PYBIND11_EMBEDDED_MODULE(_modmesh_view, mod) | ||
| PYBIND11_EMBEDDED_MODULE(_modmesh, mod) // NOLINT |
Member
Author
There was a problem hiding this comment.
Embed _modmesh to the viewer executable.
cpp/modmesh/python/common.hpp
Outdated
| OneTimeInitializer & operator=(OneTimeInitializer &&) = delete; | ||
| ~OneTimeInitializer() = default; | ||
|
|
||
| #ifdef IAMWWRONG |
Member
Author
There was a problem hiding this comment.
Dead code that I forgot to delete. Will delete it in the next commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "base" _modmesh Python extension module was built in a separate shared object and loaded into the viewer binary. Some object files need to be linked in the two images. It is unnecessarily complex. Embedding the "base" Python extension module in the same way that the "_modmesh_view" module is embedded to the viewer executable simplifies the linkage.
The pure Python module (package)
modmeshis changed accordingly. When it is used without the Qt viewer, it still tries to load the_modmeshextension module relatively.