SimpleArray: support copy data from ndarray using ellipsis #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yungyuc
requested changes
Jun 28, 2022
yungyuc
requested changes
Jun 28, 2022
Member
|
If the added patch is clear enough it is not necessary to squash. |
yungyuc
requested changes
Jun 28, 2022
tigercosmos
commented
Jun 29, 2022
tests for ghost and stride
yungyuc
requested changes
Jul 12, 2022
Member
yungyuc
left a comment
yungyuc
left a comment
There was a problem hiding this comment.
It's great to see the ellipsis support is taking shape. Thanks a lot and there are some things to be fixed.
tigercosmos
commented
Jul 14, 2022
yungyuc
reviewed
Jul 14, 2022
yungyuc
requested changes
Jul 14, 2022
yungyuc
reviewed
Jul 14, 2022
yungyuc
approved these changes
Jul 14, 2022
Member
|
Thanks a lot @tigercosmos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solve the first part of #52