Skip to content

Conversation

@tigercosmos
Copy link
Collaborator

To support the latest APIs.

@tigercosmos
Copy link
Collaborator Author

@yungyuc I don't know why there is no CI here

@yungyuc yungyuc added the test testing and continuous integration label Jun 30, 2022
@yungyuc
Copy link
Member

yungyuc commented Jun 30, 2022

CI run from first-timer contributor needs to get approval from maintainer.

This upgrade is good, but I think we need some context for future documentation (what's new log). Could you list the syntax you want to enable through the dependency upgrade? Listing right here in the PR is good.

@tigercosmos
Copy link
Collaborator Author

pybind11::array::view (code ref) has been introcuded in the current version.

@yungyuc
Copy link
Member

yungyuc commented Jun 30, 2022

Is 2.9.2 the current version you mentioned?

@tigercosmos
Copy link
Collaborator Author

yes

@yungyuc yungyuc merged commit 0154068 into solvcon:master Jun 30, 2022
@tigercosmos tigercosmos deleted the pybindupdate branch June 30, 2022 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test testing and continuous integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants