Import the turgon code base to modmesh #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The turgon github repository: https://github.com/yungyuc/turgon * The importation includes C++, Python, and Python unit tests. * Remove spacetime::python::make_SimpleArray, it duplicates with the modmesh template. * In the spacetime namespace, rename index_type to uint_type and sindex_type to int_type. The namespace `spacetime` is kept in this commit. I have not decided how it should be put under the `modmesh` namespace.
* Merge the contents of type.hpp and system.hpp in spacetime/ to modmesh/base.hpp * Rename spacetime/type.hpp to spacetime/base_spacetime.hpp as a temporary alias * Move spacetime/math.hpp to modmesh/math.hpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a giant PR and I do not anticipate that anyone would like to review it.
Turgon is an experimental 1D solver of the CESE method. It may or may not have a correct implementation, and I plan to complete it in this repository. The code will be integrated with modmesh gradually.