Skip to content

Add hamgrd to dash-ha container #23254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yue-fred-gao
Copy link
Contributor

Why I did it

hamgrd is a critical component of sonic dash HA. It was not ready until now.

Work item tracking
  • Microsoft ADO (number only):

How I did it

  1. Add hamgrd to dash-ha supervisor.conf and start it after swbusd
  2. Add hamgrd to critical_process in dash-ha container.
  3. Move src/sonic-dash-ha submodule to the latest in master branch

How to verify it

Start dash-ha container and verify hamgrd is started

Which release branch to backport (provide reason below if selected)

  • 202205
  • 202211
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@yue-fred-gao yue-fred-gao requested a review from lguohan as a code owner July 8, 2025 08:33
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@@ -1,2 +1,2 @@
program:swbusd
program:hamgrd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yue-fred-gao Do we have check for this process to be started only for smartswitch SKUs? Please check and confirm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kperumalbfn no, we don't. The process is part of dash-ha container, which is controlled by controller via FEATURE table. We don't want to limit it to smartswitch. Actually, the initial implementation enabled dash-ha feature automatically for smartswitch but we decided against it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants