-
Notifications
You must be signed in to change notification settings - Fork 612
[P4Orch] Add notification handler for p4rt. #3748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
divyagayathri-hcl
wants to merge
4
commits into
sonic-net:master
Choose a base branch
from
divyagayathri-hcl:p4orch_pr8
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
f7b01aa
to
0669b55
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
de51f19
to
94bb6dd
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
rkavitha-hcl
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Implemented handleP4rtNotification() to process runtime P4RT notifications received via AppDb.
Used enqueue() and drain() calls to apply updates to the P4 pipeline.
Why I did it
To enable dynamic, event-driven updates in SONiC’s P4RT pipeline.
P4RT-capable switches publish notification entries to AppDb; without this handler, P4Orch would ignore these updates.
How I verified it
Wrote unit tests that simulate SET and DEL notification entries.
Verified correct behavior through mocked SAI calls and test assertions.
Details if related
Test fixture P4OrchTest now initializes all required SAI mocks for independent verification.