Add the SMT solver Bitwuzla to JavaSMT#370
Merged
Merged
Conversation
…swig_cpp # Conflicts: # lib/native/source/libbitwuzla/compile.sh # src/org/sosy_lab/java_smt/solvers/bitwuzla/BitwuzlaFormulaCreator.java # src/org/sosy_lab/java_smt/solvers/bitwuzla/BitwuzlaOption.java
…lFunctionImpl as it seems unneeded.
…rom FloatingPointFormulaManagerTest.
…swig_cpp # Conflicts: # src/org/sosy_lab/java_smt/solvers/bitwuzla/BitwuzlaFloatingPointManager.java # src/org/sosy_lab/java_smt/solvers/bitwuzla/BitwuzlaOption.java
…ws us to handle arbitrary size fp values. Improved native method mk_fp_value to handle scientific notation in input strings.
…d the affected tests and added a FIXME note to BitwuzlaFloatingPointManager.
…ovides a temporary fix to the phantom reference issue.
… to bitvector, which is not supported by the solver.
…nnotation, as this filters all solvers that don't support both and add requireQuantifierElimination()
…n call that does throw the exception in its signature
…hey state that it might be corrupted
This reverts commit 18372ac.
…ves differently" This reverts commit b2479c6.
…la, as they state that it might be corrupted" This reverts commit dd009bd.
… function call that does throw the exception in its signature" This reverts commit fb8376b.
This reverts commit b979f74.
… this is problematic for OpenSMT2 and Bitwuzla)" This reverts commit 181d750.
…Before annotation, as this filters all solvers that don't support both and add requireQuantifierElimination()" This reverts commit a0b02d3.
This reverts commit ba8be95.
…legant but readable solution
Member
|
Can someone give details on the compilation process of Bitwuzla:
|
Contributor
Author
|
Thank you for your rigor!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR discusses the addition of Bitwuzla to JavaSMT.
This PR is based on 2 previous PRs:
PR332 is the original PR adding Bitwuzla support to JavaSMT
PR369 is an addition that combines PR332 with an automatic, SWIG based build script for the JNI wrapper and the most recent update of Bitwuzla with its new term manager, allowing solver instance and thread independent creation/handling of terms. The automatic, SWIG based build script generates a new wrapper based on the C++ bindings automatically for Bitwuzla. This can be toggled on and off. Also, this handles resources automatically via phantom references.
Remaining problems: