#381 improve interpolation behaviour#382
Merged
Merged
Conversation
…nterpolating solvers.
Returning the asserted term itself can cause problems if the calling context assumes uniqueness.
Previously, we tracked a single ID per asserted constraint. If we added the same constraint several times, the solver can return distinct IDs. The solution is a switch from Map to Multimap, to track all IDs.
baierd
requested changes
Jul 2, 2024
baierd
left a comment
baierd
left a comment
Contributor
There was a problem hiding this comment.
This fixes the issue nicely. And besides the 2 small change requests this can be merged with no issues.
| solver.assertFormula(exp); | ||
| } | ||
| return null; | ||
| String id = "ID_" + ID_GENERATOR.getFreshId(); |
Contributor
There was a problem hiding this comment.
I totally get what you are doing here. But wouldn't it be better to create a new class (InterpolationPoint?) that wraps this ID to make the intention clear for user and future developers?
Member
Author
There was a problem hiding this comment.
InterpolationPoint is a quite special use-case. Some solvers also use those references for unsat-cores or model generation. We can think about it independently of this issue. Maybe name the reference to something like FormulaBacktrackPoint.
…ints and remove unneeded warning suppressions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #381 for details