non-RTTI dynamic cast #2452
Merged
non-RTTI dynamic cast #2452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dynamic cast have a significant performance impact on Souffle AST/RAM pipelines. * non-RTTI dynamic cast for the ast::Node hierarchy * non-RTTI dynamic cast for the ast::analysis::Type hierarchy * non-RTTI dynamic cast for the ram::Node hierarchy
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2452 +/- ##
==========================================
+ Coverage 77.75% 78.12% +0.36%
==========================================
Files 474 486 +12
Lines 31164 32354 +1190
==========================================
+ Hits 24232 25276 +1044
- Misses 6932 7078 +146
|
julienhenry
approved these changes
Dec 8, 2023
quentin
added a commit
to quentin/souffle
that referenced
this pull request
Jun 19, 2024
Dynamic cast have a significant performance impact on Souffle AST/RAM pipelines. * non-RTTI dynamic cast for the ast::Node hierarchy * non-RTTI dynamic cast for the ast::analysis::Type hierarchy * non-RTTI dynamic cast for the ram::Node hierarchy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic cast have a significant performance impact on Souffle AST/RAM pipelines.