Skip to content

Conversation

@quentin
Copy link
Member

@quentin quentin commented Dec 19, 2023

Conjunctions with hundreds of terms would otherwise overflow the engine stack with left/right recursion.
The issue has been observed in Debug build with ~200 terms.

@codecov
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Merging #2459 (bba07d6) into master (f766700) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2459      +/-   ##
==========================================
- Coverage   78.20%   78.15%   -0.05%     
==========================================
  Files         486      486              
  Lines       32379    32394      +15     
==========================================
- Hits        25322    25318       -4     
- Misses       7057     7076      +19     
Files Coverage Δ
src/interpreter/Engine.cpp 85.21% <100.00%> (+0.04%) ⬆️
src/interpreter/Generator.cpp 95.20% <100.00%> (+0.09%) ⬆️
src/interpreter/Node.h 96.96% <ø> (ø)

... and 4 files with indirect coverage changes

@quentin quentin requested a review from julienhenry December 19, 2023 15:03
@quentin quentin requested a review from b-scholz January 31, 2024 06:55
@quentin quentin merged commit b82ae20 into souffle-lang:master Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants