Skip to content

Conversation

@quentin
Copy link
Member

@quentin quentin commented Nov 12, 2025

fix #2435
fix #2486
fix #2552

@quentin quentin force-pushed the fix-resolve-aliases branch from ebda119 to 7ba33b0 Compare November 13, 2025 07:58
@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

❌ Patch coverage is 96.26866% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.19%. Comparing base (8abf896) to head (7ba33b0).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/ast/transform/ResolveAliases.cpp 97.58% 3 Missing ⚠️
src/ast2ram/seminaive/ValueTranslator.cpp 33.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2564      +/-   ##
==========================================
+ Coverage   81.16%   81.19%   +0.02%     
==========================================
  Files         492      492              
  Lines       30953    31001      +48     
==========================================
+ Hits        25122    25170      +48     
  Misses       5831     5831              
Files with missing lines Coverage Δ
src/MainDriver.cpp 74.19% <100.00%> (+0.24%) ⬆️
src/reports/DebugReport.cpp 92.47% <ø> (ø)
src/ast2ram/seminaive/ValueTranslator.cpp 95.31% <33.33%> (-3.08%) ⬇️
src/ast/transform/ResolveAliases.cpp 97.92% <97.58%> (-1.08%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@quentin quentin marked this pull request as ready for review November 13, 2025 10:58
@quentin quentin requested a review from julienhenry November 13, 2025 10:58
Copy link
Member

@julienhenry julienhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the fixes!

@quentin quentin merged commit 89f2abe into souffle-lang:master Nov 15, 2025
36 checks passed
@quentin quentin deleted the fix-resolve-aliases branch November 15, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants