Skip to content

Remove throttle for editorValue, fix workspace bugs #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 5, 2018
Merged

Remove throttle for editorValue, fix workspace bugs #166

merged 10 commits into from
Jul 5, 2018

Conversation

ning-y
Copy link
Member

@ning-y ning-y commented Jul 5, 2018 •
edited
Loading

Features

@ning-y ning-y requested a review from remo5000 July 5, 2018 07:47
@coveralls
Copy link

coveralls commented Jul 5, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 195

  • 28 of 35 (80.0%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 31.352%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/reducers/playground.ts 1 2 50.0%
src/components/Application.tsx 17 19 89.47%
src/containers/ApplicationContainer.ts 7 9 77.78%
src/sagas/index.ts 1 3 33.33%
Files with Coverage Reduction New Missed Lines %
src/components/Playground.tsx 1 89.47%
Totals Coverage Status
Change from base Build 172: -0.04%
Covered Lines: 1199
Relevant Lines: 3361
💛 - Coveralls

remo5000
remo5000 requested changes Jul 5, 2018
View reviewed changes
Copy link
Contributor

@remo5000 remo5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just that one bug with the shared value

src/components/Playground.tsx Outdated
return parsePrgrm(this.props) || this.props.editorValue === undefined
? defaultPlaygroundText
: this.props.editorValue
return parsePrgrm(this.props) || this.props.editorValue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of 20f72c8, the playground cannot be edited after the playground link is accessed. If i recall, it is because of how an empty string acts as false in the || check. Can you try to revert this line to see if it fixes it?

@remo5000 remo5000 merged commit e85b7d7 into master Jul 5, 2018
@ning-y ning-y deleted the remove-throttle branch July 17, 2018 11:16
Aulud pushed a commit to Aulud/cadet-frontend that referenced this pull request May 25, 2020
@ning-y @indocomsoft
Fail Cadet.Public.Updater silently in dev/test environments (source-a…
68962b4 
…cademy#166)

* Add try/rescue at Cadet.Updater.Public.init/1

* Add test for failing init/1 in non-prod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remo5000 remo5000 remo5000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ning-y @coveralls @remo5000