Skip to content

Fetch user roles, and display as Popover on navbar #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 11, 2018
Merged

Conversation

ning-y
Copy link
Member

@ning-y ning-y commented Jul 9, 2018

Features

  • Backend saga now fetches role of user
  • Slice of state.session added, 'role'
  • Backend saga updates state.session.role
  • State.session.role is shown as a popover on-click of 'status button' on right of primary navbar after login

@ning-y ning-y requested a review from remo5000 July 9, 2018 07:19
@coveralls
Copy link

coveralls commented Jul 9, 2018

Pull Request Test Coverage Report for Build 267

  • 19 of 27 (70.37%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 32.41%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/Application.tsx 2 3 66.67%
src/reducers/session.ts 0 1 0.0%
src/components/academy/Status.tsx 7 9 77.78%
src/sagas/backend.ts 0 4 0.0%
Totals Coverage Status
Change from base Build 259: 0.3%
Covered Lines: 1280
Relevant Lines: 3487

💛 - Coveralls

Copy link
Contributor

@remo5000 remo5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you pass role to the academy NavBar, so that it doesn't show the "Grading" tab when the user is not authenticated?

@remo5000 remo5000 merged commit b310cbb into master Jul 11, 2018
@ning-y ning-y deleted the fetch-roles branch July 17, 2018 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants