Skip to content

Store library externals in state #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Jul 16, 2018
Merged

Store library externals in state #198

merged 27 commits into from
Jul 16, 2018

Conversation

remo5000
Copy link
Contributor

@remo5000 remo5000 commented Jul 16, 2018

Features

  • Store externals in state, to ensure a single source of truth for the externals used by js-slang.
  • Removed changeChapter
  • Changed changeLibrary to changePlaygroundExternal
  • clearContext is used to reset the context and set chapter and externals (previously library). This is because changing chapter or library will require the context to be cleared.
  • Clearing context using 'clear' button or 'Run' keeps the externals and chapter from the current context

@coveralls
Copy link

coveralls commented Jul 16, 2018

Pull Request Test Coverage Report for Build 309

  • 31 of 59 (52.54%) changed or added relevant lines in 12 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 26.018%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/actions/workspaces.ts 4 5 80.0%
src/components/Application.tsx 0 1 0.0%
src/containers/PlaygroundContainer.ts 0 1 0.0%
src/containers/academy/grading/GradingWorkspaceContainer.ts 1 2 50.0%
src/containers/assessment/AssessmentWorkspaceContainer.ts 1 3 33.33%
src/components/academy/grading/GradingWorkspace.tsx 0 2 0.0%
src/components/workspace/ControlBar.tsx 4 6 66.67%
src/containers/ApplicationContainer.ts 5 7 71.43%
src/sagas/index.ts 2 18 11.11%
Files with Coverage Reduction New Missed Lines %
src/actions/workspaces.ts 1 68.42%
Totals Coverage Status
Change from base Build 297: -0.04%
Covered Lines: 715
Relevant Lines: 2331

💛 - Coveralls

@remo5000 remo5000 changed the title [WIP] Store library externals in state Store library externals in state Jul 16, 2018
@remo5000 remo5000 mentioned this pull request Jul 16, 2018
8 tasks
@remo5000 remo5000 requested a review from ning-y July 16, 2018 08:35
export const CHANGE_SIDE_CONTENT_HEIGHT = 'CHANGE_SIDE_CONTENT_HEIGHT'
export const CHAPTER_SELECT = 'CHAPTER_SELECT'
export const LIBRARY_SELECT = 'LIBRARY_SELECT'
export const PLAYGROUND_EXTERNAL_SELECT = 'PLAYGROUND_EXTERNAL_SELECT '
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetical pls

Copy link
Member

@ning-y ning-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also sorted some other actionTypes lines
@ning-y ning-y merged commit bf91c25 into master Jul 16, 2018
@ning-y ning-y deleted the externals-in-state branch July 17, 2018 11:15
Aulud pushed a commit to Aulud/cadet-frontend that referenced this pull request May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants