-
Notifications
You must be signed in to change notification settings - Fork 172
Implement history search in repl via up/down arrows #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 312
💛 - Coveralls |
mac: 'Up' | ||
}, | ||
exec: this.execBrowseHistoryUp | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic here looks good. The multi-line issue is already addressed, so not going to mention it here
src/reducers/workspaces.ts
Outdated
[location]: { | ||
...state[location] | ||
} | ||
if (newReplHistoryRecords.length > 50) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can consider using a deque or a circular buffer, so that the size does not have to be a concern.
src/reducers/workspaces.ts
Outdated
} | ||
case EVAL_EDITOR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have added some documentation for this, my bad. It is here to force a re-render in the workspace component, showing the "Stop" button. Can it be added back? The Stop button does not show up when running e.g const fib = (x) => x <= 2? 1 : fib(x-1) + fib(x-2); fib(20);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…ce-academy#200) * Add comment field to the response of AssessmentsController.show * Address code review
Some possible improvements are documented in #199.