Implement history search in repl via up/down arrows #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 312
💛 - Coveralls |
remo5000
requested changes
Jul 16, 2018
| mac: 'Up' | ||
| }, | ||
| exec: this.execBrowseHistoryUp | ||
| }, |
There was a problem hiding this comment.
Logic here looks good. The multi-line issue is already addressed, so not going to mention it here
src/reducers/workspaces.ts
Outdated
| [location]: { | ||
| ...state[location] | ||
| } | ||
| if (newReplHistoryRecords.length > 50) { |
There was a problem hiding this comment.
You can consider using a deque or a circular buffer, so that the size does not have to be a concern.
src/reducers/workspaces.ts
Outdated
| } | ||
| case EVAL_EDITOR: |
There was a problem hiding this comment.
I should have added some documentation for this, my bad. It is here to force a re-render in the workspace component, showing the "Stop" button. Can it be added back? The Stop button does not show up when running e.g const fib = (x) => x <= 2? 1 : fib(x-1) + fib(x-2); fib(20);
Aulud
pushed a commit
to Aulud/cadet-frontend
that referenced
this pull request
May 25, 2020
…ce-academy#200) * Add comment field to the response of AssessmentsController.show * Address code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some possible improvements are documented in #199.