-
Notifications
You must be signed in to change notification settings - Fork 172
Load editorValue from solutionTemplate or answer #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a743567
to
def691f
Compare
Pull Request Test Coverage Report for Build 380
💛 - Coveralls |
cee4da3
to
9c7e233
Compare
@remo5000 Rebased to master |
src/reducers/states.ts
Outdated
@@ -58,7 +58,7 @@ export interface IWorkspaceManagerState { | |||
|
|||
interface IWorkspaceState { | |||
readonly context: Context | |||
readonly editorValue: string | |||
readonly editorValue: string | undefined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be changed to null
?
notification.show({ | ||
intent: Intent.SUCCESS, | ||
message, | ||
timeout | ||
}) | ||
} | ||
|
||
export const showWarningMessage = (message: string, timeout = 500) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, could you try timeout: number = 500
? If it doesn't work, then keeping the current change is fine too
This branch is based off #204. After that is merged, it will be rebased off master and be cleaner (5 commits).
Features
Note that all of these features apply only for programming questions. The mcq questions need fixes w.r.t. response bodies.
Todos