Skip to content

Fix display builtin not working in playground #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 23, 2018
Merged

Fix display builtin not working in playground #223

merged 3 commits into from
Jul 23, 2018

Conversation

remo5000
Copy link
Contributor

Features

  • Made the externalContext argument for createContext mandatory
  • Removed a default argument from an action creator (missed out from a rebase)

Issues fixed

remo5000 added 3 commits July 23, 2018 14:27
@remo5000
Make externalContext compulsory for frontend usage
122c50c 
This ensures the continuity of the externalContext (workspaceLocation)
even when resetting the context, as we are forced to provide the
paramter
@remo5000
Remove default value for action
9724d30
@remo5000
Format actionCreator
d8acfc8
@remo5000 remo5000 requested a review from ning-y July 23, 2018 06:39
@coveralls
Copy link

Pull Request Test Coverage Report for Build 387

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 25.473%
Totals Coverage Status
Change from base Build 385: 0.02%
Covered Lines: 754
Relevant Lines: 2512
💛 - Coveralls

@ning-y ning-y merged commit 14431f0 into master Jul 23, 2018
@ning-y ning-y deleted the fix-display branch July 23, 2018 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ning-y ning-y ning-y approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display does not work in the playground editor
3 participants
@remo5000 @coveralls @ning-y