Skip to content

Add Favicon #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 23, 2018
Merged

Add Favicon #225

merged 6 commits into from
Jul 23, 2018

Conversation

remo5000
Copy link
Contributor

Features

  • image

TODO

  • Should we keep a rounded black background?
  • Should it be bigger?
  • Should we use the yellow version instead of this one?

remo5000 added 3 commits July 23, 2018 15:25
@remo5000
Add old favicon from sourceacademy
fc7be0d
@remo5000
Add favicon GIMP file
9324ed4 
This will act as the source for the favicon
@remo5000
Replace default favicon with rendered favicon
f09babc 
Exported a .png from GIMP, then used an imagemagick command (found on
their page) to generate the .ico file
@coveralls
Copy link

coveralls commented Jul 23, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 398

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 36 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.02%) to 25.473%
Files with Coverage Reduction New Missed Lines %
src/actions/interpreter.ts 1 85.71%
src/localStorage.ts 6 35.71%
src/reducers/workspaces.ts 29 8.4%
Totals Coverage Status
Change from base Build 385: 0.02%
Covered Lines: 754
Relevant Lines: 2512
💛 - Coveralls

@martin-henz
Copy link
Member

"Cadet" should not appear anywhere as the name of the system. It should be "Source Academy". We should also not let things like "frontend" or "backend" spill over into the user namespace.

ning-y
ning-y requested changes Jul 23, 2018
View reviewed changes
Copy link
Member

@ning-y ning-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icon's good. Just change the title tag in the public index.html to fix the prof's comment and we should be good to go.

@ning-y
Copy link
Member

ning-y commented Jul 23, 2018

Actually that's pretty trivial so I'll go ahead and make the changes

@ning-y ning-y merged commit 2debe92 into master Jul 23, 2018
@ning-y ning-y deleted the favicon branch July 23, 2018 11:17
Aulud pushed a commit to Aulud/cadet-frontend that referenced this pull request May 25, 2020
@indocomsoft
Add sorting by question display order in GradingController (source-ac…
9954afd 
…ademy#225)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ning-y ning-y ning-y approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@remo5000 @coveralls @martin-henz @ning-y