Skip to content

Add UI/UX indications for unsaved changes #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 26, 2018
Merged

Add UI/UX indications for unsaved changes #236

merged 11 commits into from
Jul 26, 2018

Conversation

ning-y
Copy link
Member

@ning-y ning-y commented Jul 25, 2018

Resolves #231.

@ning-y ning-y requested a review from remo5000 July 25, 2018 09:52
@coveralls
Copy link

coveralls commented Jul 25, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 444

  • 6 of 24 (25.0%) changed or added relevant lines in 11 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.09%) to 25.265%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/actions/workspaces.ts 1 2 50.0%
src/reducers/workspaces.ts 0 1 0.0%
src/containers/assessment/AssessmentWorkspaceContainer.ts 0 1 0.0%
src/components/workspace/ControlBar.tsx 1 2 50.0%
src/containers/academy/grading/GradingWorkspaceContainer.ts 0 1 0.0%
src/sagas/backend.ts 0 1 0.0%
src/components/workspace/Editor.tsx 2 5 40.0%
src/components/assessment/AssessmentWorkspace.tsx 0 3 0.0%
src/components/academy/grading/GradingWorkspace.tsx 0 3 0.0%
src/components/workspace/index.tsx 1 4 25.0%
Files with Coverage Reduction New Missed Lines %
src/components/workspace/index.tsx 1 18.03%
src/sagas/backend.ts 1 16.5%
src/components/workspace/ControlBar.tsx 1 27.14%
Totals Coverage Status
Change from base Build 442: -0.09%
Covered Lines: 762
Relevant Lines: 2569
💛 - Coveralls

@ning-y ning-y changed the title Visually indicate and prompt user when navigating away, if has unsaved changes Add UI/UX indications for unsaved changes Jul 26, 2018
remo5000
remo5000 approved these changes Jul 26, 2018
View reviewed changes
Copy link
Contributor

@remo5000 remo5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@remo5000 remo5000 merged commit ec63beb into master Jul 26, 2018
@ning-y ning-y deleted the unsaved-work branch July 30, 2018 09:47
Aulud pushed a commit to Aulud/cadet-frontend that referenced this pull request May 25, 2020
@indocomsoft
Refactor git in CS1101S for better error reporting (source-academy#236)
f7aac1c 
* Refactor git in CS1101S for better error reporting

* Fix debug only inside non-error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remo5000 remo5000 remo5000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ning-y @coveralls @remo5000