-
Notifications
You must be signed in to change notification settings - Fork 172
Remove deleted files from open editor tabs #2386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4510868611
💛 - Coveralls |
zhaojj2209
approved these changes
Mar 25, 2023
5 tasks
RichDom2185
pushed a commit
to NUS-CS1101S/cadet-frontend
that referenced
this pull request
Jul 15, 2023
* Extract out next active editor tab index logic * Add REMOVE_EDITOR_TAB_FOR_FILE action * Add tests for REMOVE_EDITOR_TAB_FOR_FILE action * Remove corresponding open editor tab when deleting files if it exists * Add REMOVE_EDITOR_TABS_FOR_DIRECTORY action * Add tests for REMOVE_EDITOR_TABS_FOR_DIRECTORY action * Remove corresponding open editor tabs when deleting directories
Pull Request Test Coverage Report for Build 4510868611Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves the following issue that was raised by @zhaojj2209 in #2378:
Part of #2176.
Type of change
How to test
The multiple files mode is not yet ready for production and is disabled programmatically. Enable multiple files mode for testing by changing the condition to
false
:frontend/src/pages/playground/Playground.tsx
Lines 603 to 615 in 9bc1140
Then, verify that deleting files or folders from the file system view results in the corresponding editor tabs being closed.