Skip to content

Fix actual canvas element not maintaining aspect ratio #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2018
Merged

Conversation

ning-y
Copy link
Member

@ning-y ning-y commented Jul 30, 2018

Resolves #241.

The canvas element was not maintaining its aspect ratio, but the visuals of the canvas element were. Resulted in the visuals and their hover areas being 'out of sync'. Fixed with the oldest css trick in the book.

@ning-y ning-y requested a review from remo5000 July 30, 2018 04:06
@coveralls
Copy link

coveralls commented Jul 30, 2018

Pull Request Test Coverage Report for Build 479

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 25.405%

Totals Coverage Status
Change from base Build 475: 0.0%
Covered Lines: 776
Relevant Lines: 2606

💛 - Coveralls

@ning-y
Copy link
Member Author

ning-y commented Jul 30, 2018

@remo5000 Let's settle #240 first because I wanna stage a new version with that PR and this PR (and the version bump is at this PR so this one has to go second).

@remo5000 remo5000 merged commit 285143c into master Jul 30, 2018
@ning-y ning-y deleted the game-display branch July 30, 2018 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants