-
Notifications
You must be signed in to change notification settings - Fork 172
Migrate to rsbuild and swc #3131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a preliminary quick review of the code changes, although I'm not too sure for the testing updates. As long as they are passing (which they appear to do so), I think it should not be too far off.
I have also yet to run the code locally, so here are just some questions and ideas from me after glancing over the changes, let me know what you think!
Previously with Webpack it would compile away the dynamic import used to import modules (because there was no way to |
@leeyi45 I think I saw this comment somewhere, but wasn't too sure what it entailed in terms of testing. I had tried running some module code in the playground and it seems to work, though I'm not sure if that is what you mean. Would you mind checking as well? Thank you! |
Did a quick review. I think on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested yarn start
and yarn build
locally with no issues found. LGTM!
port: 8000 | ||
}, | ||
tools: { | ||
// TODO: See if still needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will we need these commented code in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's mainly kept as reference since the original file was deleted (so it would be hard to get a "file history" since the old webpack config won't be present in the current repo anymore).
Now that this PR is merged, it's free to be deleted as one can always look at the file history of rsbuild.config.ts to easily see what the original webpack config was
Description
CRA is dead. Switch to rsbuild (which uses rspack → drop-in for webpack → powers CRA), but written in Rust so much faster.
Type of change
How to test
Everything should (and does) still work since it's effectively drop in.
Checklist