Skip to content

Clicking on Diamond Logo - Broken Link #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2018
Merged

Clicking on Diamond Logo - Broken Link #315

merged 2 commits into from
Aug 21, 2018

Conversation

rrtheonlyone
Copy link
Contributor

Reference to issue #305

PR #308 changes openWristDevice() to history.push(). However, this is a relative change and window.open() is required to change URL to IVLE.

@rrtheonlyone rrtheonlyone requested a review from ning-y August 20, 2018 06:15
@rrtheonlyone
Copy link
Contributor Author

Updated all history push for redirect to IVLE and renamed LUMINUS to IVLE

@coveralls
Copy link

Pull Request Test Coverage Report for Build 685

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 26.08%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/academy/game/create-initializer.js 0 4 0.0%
Totals Coverage Status
Change from base Build 679: 0.0%
Covered Lines: 887
Relevant Lines: 2893

💛 - Coveralls

@ning-y ning-y requested review from remo5000 and removed request for ning-y August 20, 2018 13:30
Copy link
Contributor

@remo5000 remo5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the PR!

@remo5000 remo5000 merged commit 6580835 into master Aug 21, 2018
@rrtheonlyone rrtheonlyone deleted the LINK-FIX branch August 22, 2018 04:37
Aulud pushed a commit to Aulud/cadet-frontend that referenced this pull request May 25, 2020
* expose student info

* rm newline

* made changes from review

* made changes from review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants