Skip to content

Add XP to Profile #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 23, 2018
Merged

Add XP to Profile #318

merged 6 commits into from
Aug 23, 2018

Conversation

remo5000
Copy link
Contributor

@remo5000 remo5000 commented Aug 22, 2018

Features

  • XP and grade values are 0 by default (less dependence on undefined values)
  • Betcha button is enabled
  • Progress bar is enabled

Issues fixes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 688

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 26.065%

Totals Coverage Status
Change from base Build 686: -0.02%
Covered Lines: 885
Relevant Lines: 2890

💛 - Coveralls

@remo5000 remo5000 requested review from ning-y, indocomsoft and rrtheonlyone and removed request for ning-y August 23, 2018 01:33
@ning-y
Copy link
Member

ning-y commented Aug 23, 2018

Might want to indicate that betcha is enabled with this PR. Also reminder to bump version and make release notes and deploy.

Copy link
Contributor

@rrtheonlyone rrtheonlyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

PR adds:

  • 'Betcha' button for extra EXP
  • Progress Bars in profile for grade / EXP

@remo5000 remo5000 merged commit ed14771 into master Aug 23, 2018
remo5000 added a commit that referenced this pull request Aug 24, 2018
@remo5000 remo5000 mentioned this pull request Aug 24, 2018
1 task
remo5000 added a commit that referenced this pull request Aug 24, 2018
@rrtheonlyone rrtheonlyone deleted the xp-profile branch September 12, 2018 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable grade progress bar
4 participants