Skip to content

Integrate color function from CP3108 project #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2018
Merged

Conversation

thenaesh
Copy link
Contributor

This PR integrates the color function written by @adamwth into the frontend. This will allow the rune contests to have the full spectrum of colors.

@thenaesh thenaesh requested a review from remo5000 August 26, 2018 15:57
@coveralls
Copy link

Pull Request Test Coverage Report for Build 752

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 26.08%

Totals Coverage Status
Change from base Build 712: 0.0%
Covered Lines: 887
Relevant Lines: 2893

💛 - Coveralls

Copy link
Contributor

@remo5000 remo5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for porting this over @thenaesh! Could this PR be added for the grader repo as well? We don't want to exclude the grader from this function

@thenaesh
Copy link
Contributor Author

@remo5000 The grader thing we'll need to KIV first, I don't know how the grader is going to deal with colours that vary very slightly. It may take a while and quite a lot of testing, so I can't do it so soon.

@thenaesh thenaesh merged commit 5dcf239 into master Aug 27, 2018
@rrtheonlyone rrtheonlyone deleted the integrate-rune-color branch September 12, 2018 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants