Skip to content

Adjust xp linearly according to adjusted grade. #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 5, 2018
Merged

Adjust xp linearly according to adjusted grade. #348

merged 5 commits into from
Sep 5, 2018

Conversation

blackening
Copy link
Contributor

@blackening blackening commented Sep 3, 2018 •
edited by remo5000
Loading

Features

image

  • Automatic scaling from grade -> xp.
  • Bump version to 1.0.9

@coveralls
Copy link

coveralls commented Sep 3, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 820

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 21 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 25.794%
Files with Coverage Reduction New Missed Lines %
src/actions/workspaces.ts 5 69.05%
src/sagas/index.ts 16 18.83%
Totals Coverage Status
Change from base Build 802: 0.02%
Covered Lines: 896
Relevant Lines: 2940
💛 - Coveralls

@blackening blackening closed this Sep 3, 2018
@blackening blackening reopened this Sep 3, 2018
remo5000
remo5000 requested changes Sep 4, 2018
View reviewed changes
Copy link
Contributor

@remo5000 remo5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but could you add a failsafe for assessments with maxGrade of 0?
image

@blackening
Copy link
Contributor Author

Ok, as requested, done. Was held up with yarn test. I suspect yarn test doesn't work on windows...

@remo5000 remo5000 merged commit de811f7 into source-academy:master Sep 5, 2018
Aulud pushed a commit to Aulud/cadet-frontend that referenced this pull request May 25, 2020
@jiachen247 @indocomsoft
Update readme to swap setup steps (source-academy#348)
c8fc172
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remo5000 remo5000 remo5000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blackening @coveralls @remo5000