Skip to content

Tone Matrix Side Content Addition - Quest 5B #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 10, 2018
Merged

Conversation

rrtheonlyone
Copy link
Contributor

Quest 5B requires a tone matrix to be displayed in the side panel. This PR helps to enable that!

screen shot 2018-09-06 at 3 05 01 pm

@coveralls
Copy link

coveralls commented Sep 6, 2018

Pull Request Test Coverage Report for Build 846

  • 7 of 15 (46.67%) changed or added relevant lines in 3 files are covered.
  • 51 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.1%) to 25.908%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/assessment/AssessmentWorkspace.tsx 3 4 75.0%
src/components/workspace/side-content/ToneMatrix.tsx 3 10 30.0%
Files with Coverage Reduction New Missed Lines %
src/mocks/gradingAPI.ts 6 23.08%
src/components/academy/grading/index.tsx 14 25.81%
src/components/assessment/index.tsx 14 81.2%
src/sagas/backend.ts 17 4.78%
Totals Coverage Status
Change from base Build 821: 0.1%
Covered Lines: 903
Relevant Lines: 2955

💛 - Coveralls

@remo5000 remo5000 merged commit a9c88e5 into master Sep 10, 2018
@rrtheonlyone rrtheonlyone deleted the quest5B-addition branch September 11, 2018 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants