-
Notifications
You must be signed in to change notification settings - Fork 172
Add question number to ControlBar #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 848
💛 - Coveralls |
@jiachen247 Thanks for the initiative! This looks good so far, but I feel that with the inclusion of question numbers, the logic behind having previous/next/return buttons can be shifted to the ControlBar. This means that |
@remo5000 yepps!!! totally agreee - cleaner this way :-) have shifted responsibility of flow control entirely into the control bar. hope it helps!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jiachen247 Whoops, it seems like you pushed without formatting and updating the tests -- could you run |
@remo5000 great! have formatted the code and have updated the failing snapshots :-) |
@jiachen247 Merged, cheers! |
@remo5000 when will the changes go live? haha |
@jiachen247 We're going to be deploying v1.0.9 soon 🤞 |
@remo5000 sounds good man! looking forward to it. thanks for all the hard work!! its an amazing platform :-) |
Previously, when students do the missions/quizzes we have no clue how many questions the mission contains.
This makes it much easier to track progress when doing any kind of assessment.